Add BigQuery subscriptions to Pubsub module. #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pubsub can now have subscriptions that write directly to BigQuery. * https://cloud.google.com/pubsub/docs/bigquery In the Google Terraform provider, this is configured using an additional block inside a `google_pubsub_subscription` resource. * https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/pubsub_subscription#nested_bigquery_config This PR adds a new input variable to the `pubsub` module, to optionally add this block to some of the subscriptions defined in the module.
juliocc
approved these changes
Nov 21, 2022
ludoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pubsub can now have subscriptions that write directly to BigQuery.
In the Google Terraform provider, this is configured using an additional block inside a
google_pubsub_subscriptionresource.This PR adds a new input variable to the
pubsubmodule, to optionally add this block to some of the subscriptions defined in the module.